-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Add degrees alias to rad2deg. #42910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit d02863a (more details on the Dr. CI page):
🕵️ 14 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
0dfa6d7 to
3cdc06a
Compare
3cdc06a to
6a08010
Compare
6a08010 to
ca43c3e
Compare
|
Unfortunately you'll need to rebase because #42802 introduced a new way of adding aliases. It should be pretty simple, though. |
042efe2 to
80f8990
Compare
|
The Windows CI builds have an internal compiler error, possibly related, but this PR isn't the source of the issue I think. The Linux CI jobs fail with: Traceback (most recent call last):
File "/var/lib/jenkins/workspace/test/test_jit.py", line 6330, in test_math_ops
checkMathWrap(op, 1)
File "/var/lib/jenkins/workspace/test/test_jit.py", line 6256, in checkMathWrap
checkMath(func_name, num_args, True, **args)
File "/var/lib/jenkins/workspace/test/test_jit.py", line 6286, in checkMath
cu = torch.jit.CompilationUnit(funcs_str)
File "/opt/conda/lib/python3.6/site-packages/torch/jit/_script.py", line 1078, in __init__
self.define(lang, _frames_up=_frames_up + 1)
File "/opt/conda/lib/python3.6/site-packages/torch/jit/_script.py", line 1083, in define
self._c.define(lang, rcb)
RuntimeError: replace_node->maybeOperator() INTERNAL ASSERT FAILED at "/var/lib/jenkins/workspace/torch/csrc/jit/passes/normalize_ops.cpp":38, please report a bug to PyTorch. invalid symbol replacement:140136Which I've tried and failed to fix, even after asking internally. |
Unfortunately Windows CI builds were broken for awhile. Sorry about that and the confusion it caused. The Linux issue is more interesting. It turns out that the JIT already defines pytorch/torch/jit/_builtins.py Line 67 in 9c8021c
It does this because the JIT supports a subset of Python, so it has implemented many Python builtins. This means that unconditionally converting from degrees to another name won't work, because the alias is attempting to convert these calls, too! We could probably reverse the alias and have |
|
@mruberry I think we can add a check that the node has inputs and the first input is a Tensor before doing the alias replacement, that would fix this issue. Another fix would be to match on the full schema instead of just the kind in checking if there's an alias. |
No description provided.