Skip to content

Fix TE microbenchmark harness to use appropriate fuser/executor #42900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bertmaher wants to merge 3 commits into from
Closed

Fix TE microbenchmark harness to use appropriate fuser/executor #42900

bertmaher wants to merge 3 commits into from

Conversation

@bertmaher
Copy link
Contributor

@bertmaher bertmaher commented Aug 12, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D23079715

This was referenced Aug 12, 2020
Closed
Closed
@dr-ci
Copy link

dr-ci bot commented Aug 12, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit e19ad02 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

ZolotukhinM
ZolotukhinM approved these changes Aug 12, 2020
View reviewed changes
Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

benchmarks/tensorexpr/__main__.py Outdated
import torch
torch._C._jit_set_profiling_executor(False)
torch._C._jit_set_texpr_fuser_enabled(False)
torch._C._jit_set_profiling_mode(False)
Copy link

@ZolotukhinM ZolotukhinM Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: technically set_profiling_mode is unneeded after we call _jit_set_profiling_executor(False). Also, since the fuser was specifically requested to be "old" it might make sense to turn it on explicitly rather than relying on a default value ( torch._C._jit_override_can_fuse_on_gpu(True))

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 13, 2020

@bertmaher merged this pull request in 33d209b.

@facebook-github-bot facebook-github-bot deleted the gh/bertmaher/5/head branch August 16, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zheng-xq zheng-xq Awaiting requested review from zheng-xq

@nickgg nickgg Awaiting requested review from nickgg

1 more reviewer

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bertmaher @facebook-github-bot @ZolotukhinM @mruberry