Speed up CUDA kernel launch when block/thread extents are statically known #42899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…known [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
This was referenced Aug 12, 2020
nickgg
reviewed
Aug 12, 2020
| // TODO: eventually, codegen these calculations and make them part of the | ||
| // module. | ||
| for (size_t i = 0; i < gpu_block_extents.size(); i++) { | ||
| auto extent = dynamic_cast<const IntImm*>(gpu_block_extents[i]); |
Contributor
There was a problem hiding this comment.
It's almost certainly an int, but supporting more dtypes doesn't cost us much here:
if (gpu_block_extents[i]->isConstant()) {
gpu_block_extents_v[i] = immediateAs<int>(gpu_block_extents[i]);
}
nickgg
approved these changes
Aug 12, 2020
…statically known" Differential Revision: [D23078708](https://our.internmc.facebook.com/intern/diff/D23078708) [ghstack-poisoned]
…statically known" Differential Revision: [D23078708](https://our.internmc.facebook.com/intern/diff/D23078708) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 49a3618 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
zheng-xq
approved these changes
Aug 12, 2020
Contributor
|
@bertmaher merged this pull request in 1adeed2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D23078708