Python/C++ API Parity: TransformerDecoder #42886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinodSKumar
requested review from
ebetica,
goldsborough and
yf225
as code owners
💊 CI failures summary and remediationsAs of commit 8db1bc0 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 51 times. |
zhangguanheng66
added
module: cpp
glaringlee
changed the title
VinodSKumar
force-pushed
the
CPP_API_TransformerDecoder
branch
from
9e57c1b to
869af62
Compare
VinodSKumar
force-pushed
the
CPP_API_TransformerDecoder
branch
from
869af62 to
69ad3ff
Compare
VinodSKumar
changed the title
VinodSKumar
force-pushed
the
CPP_API_TransformerDecoder
branch
2 times, most recently
from
e1481fb to
0e84520
Compare
glaringlee
requested changes
Aug 24, 2020
VinodSKumar
force-pushed
the
CPP_API_TransformerDecoder
branch
2 times, most recently
from
fe2d45c to
ad92a91
Compare
VinodSKumar
force-pushed
the
CPP_API_TransformerDecoder
branch
from
ad92a91 to
8db1bc0
Compare
Codecov Report
@@ Coverage Diff @@
## master #42886 +/- ##
=======================================
Coverage 69.34% 69.34%
=======================================
Files 378 378
Lines 46680 46680
=======================================
Hits 32370 32370
Misses 14310 14310 Continue to review full report at Codecov.
|
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
glaringlee
approved these changes
Aug 27, 2020
Contributor
glaringlee
left a comment
glaringlee
left a comment
There was a problem hiding this comment.
LGTM now, thanks a lot for contributing.
Contributor
|
@glaringlee merged this pull request in 13c7c62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{37756}