Skip to content

Enable input pointer caching in XNNPACK integration. #42840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kimishpatel wants to merge 28 commits into from
Closed

Enable input pointer caching in XNNPACK integration. #42840

kimishpatel wants to merge 28 commits into from

Conversation

@kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Aug 11, 2020 •
edited
Loading

Stack from ghstack:

Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D23044585

@kimishpatel
Enable input pointer caching in XNNPACK integration.
48a9e44 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Aug 11, 2020
Closed
Closed
Closed
Closed
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
3a6de24 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 11, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
7e54bdd 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 54b8094
Pull Request resolved: #42840
@dr-ci
Copy link

dr-ci bot commented Aug 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ad2a62e (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 160 times.

@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
ac537c8 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 11, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
f099106 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ff6e65d
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
aee76fd 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 11, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
195ca03 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 220d1b2
Pull Request resolved: #42840
AshkanAliabadi
AshkanAliabadi approved these changes Aug 12, 2020
View reviewed changes
aten/src/ATen/native/xnnpack/Common.h Outdated
std::array<int64_t, 2> padding_;
std::array<int64_t, 2> stride_;
std::array<int64_t, 2> dilation_;
float* cached_input_ptr{nullptr};
Copy link
Contributor

@AshkanAliabadi AshkanAliabadi Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const float*?

aten/src/ATen/native/xnnpack/Convolution.cpp
padded_input_nhwc.size(Layout::Activation4D::height) ||
context.input_width !=
padded_input_nhwc.size(Layout::Activation4D::width)
) {
Copy link
Contributor

@AshkanAliabadi AshkanAliabadi Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal opinion:

  1. Consider using parentheses liberally.
  2. I try to put rvalues (or more pedantically prvalues) on the left side of comparisons. That way == or != misspelled as = triggers a compiler error. Otherwise it is a warning, but it is typical in codebases where a 'warning as error' policy is not enforced to fall into the habit of ignoring warnings.

Please feel free to ignore. Both of these the pedantic side.

Copy link
Contributor Author

@kimishpatel kimishpatel Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly agree withe second one. I will make those changes. I weakly agree with first one :).

@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
47b9f5e 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 12, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
feed491 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 7676848
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
ad11b9c 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
6b9ff21 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
aade9df 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 13, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
34f6897 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 7ae6437
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
1fa613a 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
844241b 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
9aed129 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
2a6f023 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
349ffbe 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 18, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
8612f06 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 8d445ea
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
971a512 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
0a20850 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
617dde1 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
c5a1193 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 18, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
e9f2a59 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: fc976c9
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
5aefbc0 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 19, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
a87c49b 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 377d914
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
3eaf236 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 19, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
5364ea7 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: d4aa0e9
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
97af03b 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
dd1f0c1 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 19, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
c58a11b 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 8fac33f
Pull Request resolved: #42840
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
1fcb32a 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
@kimishpatel
Update on "Enable input pointer caching in XNNPACK integration."
ad2a62e 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23044585](https://our.internmc.facebook.com/intern/diff/D23044585)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Aug 21, 2020
@kimishpatel
Enable input pointer caching in XNNPACK integration.
a799c63 
Summary:
By caching input/output pointers and input parameters we enable the use
of caching allocator and check if we get the same input/output pointers.
If so we skip setup steps.

Test Plan:
python test/test_xnnpack_integration.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c834507
Pull Request resolved: #42840
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 23, 2020

This pull request has been merged in b003f2c.

@facebook-github-bot facebook-github-bot deleted the gh/kimishpatel/39/head branch August 26, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss Awaiting requested review from dreiss

1 more reviewer

@AshkanAliabadi AshkanAliabadi AshkanAliabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kimishpatel @facebook-github-bot @AshkanAliabadi @mruberry