Support boolean key in dictionary #42833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 1c81c8f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
asuhan
force-pushed
the
asuhan/bool_dictkey
branch
from
125481d to
1c81c8f
Compare
gmagogsfm
approved these changes
Aug 11, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
pushed a commit
to facebookresearch/detectron2
that referenced
this pull request
Aug 15, 2020
Summary: pytorch/pytorch#42833 boolean key in dictionary is now supported in pytorch1.7.0, so these hacks can be removed. Pull Request resolved: #1897 Reviewed By: alexander-kirillov Differential Revision: D23142361 Pulled By: ppwwyyxx fbshipit-source-id: 677dc47ae6f65851e0173b2819199c47e0671752
|
@asuhan is this in pytorch 1.6? thanks! |
Contributor
Author
|
@fra-luc No, it's not. |
|
@asuhan Thank you, will this be in 1.7? |
Contributor
Author
|
@fra-luc Yes, it will be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41449 .