MAINT: speed up istft by using col2im (the original python code used … #42826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mattip Thanks for resolving this! Is it as fast as the original Python version? |
smessmer
added
the
triaged
💊 CI failures summary and remediationsAs of commit f38aa75 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
mthrok
approved these changes
Aug 11, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mthrok has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Now the script (from the same setup as in the issue) is at least as fast as the previous version. Here are the timings : Before: After: |
Contributor
Thanks! This is great! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42213
The original python code from
torchaudiowas converted to a native function, but usedeyeto allocate a Tensor and was much slower.Using
at::col2im(which is the equivalent oftorch.nn.functional.fold) solved the slowdown.