Skip to content

Initial quantile operator implementation #42755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
heitorschueroff wants to merge 2 commits into from
Closed

Initial quantile operator implementation #42755

heitorschueroff wants to merge 2 commits into from

Conversation

@heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Aug 7, 2020 •
edited
Loading

Stack from ghstack:

Attempting to land quantile again after being landed here #39417 and reverted here #41616.

Differential Revision: D23030338

@heitorschueroff
Initial quantile operator implementation
9bb9e47 
Author:    Heitor Schueroff <heitorschueroff@fb.com>
Date:      Mon Jun 8 09:18:02 2020 -0700

[ghstack-poisoned]
heitorschueroff added a commit that referenced this pull request Aug 7, 2020
@heitorschueroff
Initial quantile operator implementation
f0b9ee7 
Author:    Heitor Schueroff <heitorschueroff@fb.com>
Date:      Mon Jun 8 09:18:02 2020 -0700

ghstack-source-id: b56c589
Pull Request resolved: #42755
mruberry
mruberry reviewed Aug 10, 2020
View reviewed changes
@mruberry mruberry self-requested a review August 10, 2020 12:06
mruberry
mruberry approved these changes Aug 10, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped! Looking forward to having this back in the build.

@heitorschueroff
Update on "Initial quantile operator implementation"
81bcddc 
Attempting to land quantile again after being landed here #39417 and reverted here #41616.

[ghstack-poisoned]
heitorschueroff added a commit that referenced this pull request Aug 10, 2020
@heitorschueroff
Initial quantile operator implementation
c656366 
Author:    Heitor Schueroff <heitorschueroff@fb.com>
Date:      Mon Jun 8 09:18:02 2020 -0700

ghstack-source-id: b5110c8
Pull Request resolved: #42755
@dr-ci
Copy link

dr-ci bot commented Aug 10, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 81bcddc (more details on the Dr. CI page):

  • 4/4 failures possibly* introduced in this PR
    • 2/4 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_linux_libtorch_3_7m_cpu_devtoolset7_shared-with-deps_build (1/2)

Step: "Checkout pytorch/builder repo" (full log | diagnosis details | 🔁 rerun)

fatal: reference is not a tree: f015d698006c4a11be15b1ebb75b3b9bb317b914 
+ sleep 2 
+ git submodule update --init --recursive 
fatal: reference is not a tree: f015d698006c4a11be15b1ebb75b3b9bb317b914 
Unable to checkout 'f015d698006c4a11be15b1ebb75b3b9bb317b914' in submodule path 'third_party/tensorpipe' 
+ sleep 4 
+ git submodule update --init --recursive 
fatal: reference is not a tree: f015d698006c4a11be15b1ebb75b3b9bb317b914 
Unable to checkout 'f015d698006c4a11be15b1ebb75b3b9bb317b914' in submodule path 'third_party/tensorpipe' 
+ sleep 8 
+ git submodule update --init --recursive 
fatal: reference is not a tree: f015d698006c4a11be15b1ebb75b3b9bb317b914 
Unable to checkout 'f015d698006c4a11be15b1ebb75b3b9bb317b914' in submodule path 'third_party/tensorpipe'

See CircleCI build caffe2_onnx_main_py3_6_clang7_ubuntu16_04_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Aug 10 13:49:40 fatal: reference is not a tree: f015d698006c4a11be15b1ebb75b3b9bb317b914 
DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/caffe2/py3.6-clang7-ubuntu16.04:376 
 
real	0m38.047s 
user	0m0.112s 
sys	0m0.073s 
Aug 10 13:48:37 ++ export BUILD_ENVIRONMENT=caffe2-onnx-main-py3.6-clang7-ubuntu16.04-build 
Aug 10 13:48:37 ++ BUILD_ENVIRONMENT=caffe2-onnx-main-py3.6-clang7-ubuntu16.04-build 
Aug 10 13:48:37 ++ git submodule sync 
Aug 10 13:48:38 ++ git submodule update -q --init --recursive 
Aug 10 13:49:40 fatal: reference is not a tree: f015d698006c4a11be15b1ebb75b3b9bb317b914 
Aug 10 13:49:43 Unable to checkout 'f015d698006c4a11be15b1ebb75b3b9bb317b914' in submodule path 'third_party/tensorpipe'

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2020

@heitorschueroff merged this pull request in c660d2a.

@facebook-github-bot facebook-github-bot deleted the gh/heitorschueroff/4/head branch August 15, 2020 14:17
@mruberry mruberry mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heitorschueroff @facebook-github-bot @mruberry