Skip to content

[vulkan][op] add.Scalar, mul.Scalar #42674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IvanKobzarev wants to merge 7 commits into from
Closed

[vulkan][op] add.Scalar, mul.Scalar #42674

IvanKobzarev wants to merge 7 commits into from

Conversation

@IvanKobzarev
Copy link
Contributor

@IvanKobzarev IvanKobzarev commented Aug 6, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22978763

This was referenced Aug 6, 2020
Closed
Closed
@dr-ci
Copy link

dr-ci bot commented Aug 6, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 920fb79 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Sep 14 15:50:43 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n return ((int*)(&strtod_l))[argc];\n ^\n1 error generated.\n" } 
Sep 14 15:50:43 [100%] Linking CXX executable test_custom_backend 
Sep 14 15:50:43 /opt/conda/bin/cmake -E cmake_link_script CMakeFiles/test_custom_backend.dir/link.txt --verbose=1 
0:43 /opt/cache/bin/clang++    -rdynamic CMakeFiles/test_custom_backend.dir/test_custom_backend.cpp.o  -o test_custom_backend -Wl,-rpath,/var/lib/jenkins/custom-backend-build:/opt/conda/lib/python3.6/site-packages/torch/lib libcustom_backend.so /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch.so /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so -lpthread /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so  
Sep 14 15:50:43 make[2]: Leaving directory '/var/lib/jenkins/custom-backend-build' 
Sep 14 15:50:43 [100%] Built target test_custom_backend 
Sep 14 15:50:43 make[1]: Leaving directory '/var/lib/jenkins/custom-backend-build' 
Sep 14 15:50:43 /opt/conda/bin/cmake -E cmake_progress_start /var/lib/jenkins/custom-backend-build/CMakeFiles 0 
Sep 14 15:50:43 ~/workspace 
Sep 14 15:50:43 EXITED_USER_LAND 
Sep 14 15:50:43 =================== sccache compilation log =================== 
Sep 14 15:50:43 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n  return ((int*)(&strtod_l))[argc];\n                  ^\n1 error generated.\n" } 
Sep 14 15:50:43  
Sep 14 15:50:43 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Sep 14 15:50:43 Compile requests              6125 
Sep 14 15:50:43 Compile requests executed     3622 
Sep 14 15:50:43 Cache hits                    3606 
Sep 14 15:50:43 Cache misses                     0 
Sep 14 15:50:43 Cache timeouts                   0 
Sep 14 15:50:43 Cache read errors                0 
Sep 14 15:50:43 Forced recaches                  0 
Sep 14 15:50:43 Cache write errors               0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 12 times.

@IvanKobzarev
Update on "[vulkan][op] add.Scalar, mul.Scalar"
68220dd 
Differential Revision: [D22978763](https://our.internmc.facebook.com/intern/diff/D22978763)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan][op] add.Scalar, mul.Scalar"
846222a 
Differential Revision: [D22978763](https://our.internmc.facebook.com/intern/diff/D22978763)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan][op] add.Scalar, mul.Scalar"
ce7a0de 
Differential Revision: [D22978763](https://our.internmc.facebook.com/intern/diff/D22978763)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan][op] add.Scalar, mul.Scalar"
14e2d02 
Differential Revision: [D22978763](https://our.internmc.facebook.com/intern/diff/D22978763)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan][op] add.Scalar, mul.Scalar"
e8c6662 
Differential Revision: [D22978763](https://our.internmc.facebook.com/intern/diff/D22978763)

[ghstack-poisoned]
@codecov
Copy link

codecov bot commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #42674 into gh/IvanKobzarev/72/base will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           gh/IvanKobzarev/72/base   #42674      +/-   ##
===========================================================
+ Coverage                    68.00%   69.25%   +1.24%     
===========================================================
  Files                          384      378       -6     
  Lines                        49599    46862    -2737     
===========================================================
- Hits                         33728    32452    -1276     
+ Misses                       15871    14410    -1461
Impacted Files Coverage Δ
torch/distributed/nn/api/remote_module.py 34.21% <0.00%> (-10.53%) ⬇️
torch/_six.py 91.42% <0.00%> (-8.58%) ⬇️
torch/quantization/fx/fuse.py 91.53% <0.00%> (-8.47%) ⬇️
torch/testing/_internal/common_nn.py 77.64% <0.00%> (-5.62%) ⬇️
torch/quantization/__init__.py 83.33% <0.00%> (-4.17%) ⬇️
torch/quantization/fx/quantize.py 93.23% <0.00%> (-3.98%) ⬇️
torch/utils/_benchmark/utils/timer.py 85.18% <0.00%> (-3.71%) ⬇️
torch/backends/cudnn/__init__.py 56.33% <0.00%> (-3.41%) ⬇️
torch/testing/_internal/common_distributed.py 65.86% <0.00%> (-2.28%) ⬇️
torch/_tensor_str.py 85.65% <0.00%> (-2.11%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68a99b...920fb79. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 15, 2020

@IvanKobzarev merged this pull request in 8f327cd.

@facebook-github-bot facebook-github-bot deleted the gh/IvanKobzarev/72/head branch September 18, 2020 14:17
xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@IvanKobzarev @xuzhao9
[vulkan][op] add.Scalar, mul.Scalar (#42674)
c2ecaba 
Summary: Pull Request resolved: #42674

Test Plan: Imported from OSS

Reviewed By: AshkanAliabadi

Differential Revision: D22978763

Pulled By: IvanKobzarev

fbshipit-source-id: 9fd97d394205e3fa51992ee99d5bfafc33f75efa
loadbxh pushed a commit to loadbxh/Torch that referenced this pull request Sep 23, 2020
@IvanKobzarev
[vulkan][op] add.Scalar, mul.Scalar
10af1b3 
ghstack-source-id: 9e1c02e
Pull Request resolved: pytorch/pytorch#42674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss Awaiting requested review from dreiss

1 more reviewer

@AshkanAliabadi AshkanAliabadi AshkanAliabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanKobzarev @facebook-github-bot @AshkanAliabadi @mruberry