BAND, BOR and BXOR for NCCL (all_)reduce should throw runtime errors #42669
Conversation
thinking-tower
requested review from
mrshenli,
pietern,
pritamdamania87 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 1130ac4 (more details on the Dr. CI page):
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
Thanks for the contribution, it looks great! Requesting changes for the assertRaisesRegex, and there are also a couple of python lint issues. You can view those by clicking on the failed CI job (we should have inline annotations as well, but those seem to not be working right now).
thinking-tower
changed the title
ailzhang
added
the
triaged
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
Looks good, thanks @thinking-tower!
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@rohan-varma merged this pull request in 6ebc050. |
6 participants
cc @rohan-varma
Fixes #41362 #39708
Description
NCCL doesn't support
BAND, BOR, BXOR. Since the current mapping doesn't contain any of the mentioned bitwise operator, a default value ofncclSumis used instead.This PR should provide the expected behaviour where a runtime exception is thrown.
Notes