Adds torch.linalg namespace #42664
Closed
Adds torch.linalg namespace #42664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruberry
added
the
module: numpy
mruberry
requested review from
albanD,
apaszke,
ebetica,
goldsborough and
yf225
as code owners
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 962dec2 (more details on the Dr. CI page):
1 job timed out:
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
Contributor
|
Here is the reference page for numpy.linalg. The equivalent pytorch functions:
Should I move this to a tracking issue? |
Collaborator
Author
|
@mattip A tracking issue with those functions would be great! |
4 tasks
mruberry
requested review from
bhosmer and
gchanan
and removed request for
bhosmer
kurtamohler
reviewed
Aug 6, 2020
torch/linalg/__init__.py
Outdated
| Tensor = torch.Tensor | ||
|
|
||
| # Note: This not only adds the doc strings for the spectral ops, but | ||
| # connects the torch.fft Python namespace to the torch._C._fft builtins. |
Collaborator
There was a problem hiding this comment.
Suggested change
| # connects the torch.fft Python namespace to the torch._C._fft builtins. | |
| # connects the torch.linalg Python namespace to the torch._C._linalg builtins. |
gchanan
approved these changes
Aug 6, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
torch.linalgnamespace as part of our continued effort to be more compatible with NumPy. The namespace is tested by adding a single function,torch.linalg.outer, and testing it in a new test suite, test_linalg.py. It follows the same pattern that #41911, which added thetorch.fftnamespace, did.Future PRs will likely:
torch.linalgin preference to the new namespace