Skip to content

Raise error if at::native::embedding is given 0-D weight #42550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kurtamohler wants to merge 1 commit into from
Closed

Raise error if at::native::embedding is given 0-D weight #42550

kurtamohler wants to merge 1 commit into from

Conversation

@kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Aug 4, 2020

Previously, at::native::embedding implicitly assumed that the weight argument would be 1-D or greater. Given a 0-D tensor, it would segfault. This change makes it throw a RuntimeError instead.

Fixes #41780

@kurtamohler kurtamohler requested review from albanD and mruberry August 4, 2020 19:04
@dr-ci
Copy link

dr-ci bot commented Aug 4, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fd7b249 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 7, 2020
albanD
albanD approved these changes Aug 10, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix !

facebook-github-bot
facebook-github-bot reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2020

@albanD merged this pull request in 42b4a71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@albanD albanD albanD approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

segfault in torch.nn.functional.embedding

6 participants

@kurtamohler @facebook-github-bot @albanD @ailzhang @pytorchbot @mruberry