[JIT] Fix torch.jit.is_tracing() #42486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This commit fixes a small bug in which `torch.jit.is_tracing()` returns `torch._C.is_tracing`, the function object, instead of calling the function and returning the result. **Test Plan** Continuous integration? **Fixes** This commit fixes #42448. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Aug 3, 2020
**Summary** This commit fixes a small bug in which `torch.jit.is_tracing()` returns `torch._C.is_tracing`, the function object, instead of calling the function and returning the result. **Test Plan** Continuous integration? **Fixes** This commit fixes #42448. ghstack-source-id: f78319d Pull Request resolved: #42486
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 75c25ef (more details on the Dr. CI page):
❄️ 2 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
suo
approved these changes
Aug 3, 2020
Contributor
|
@SplitInfinity merged this pull request in 29700c0. |
This was referenced Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit fixes a small bug in which
torch.jit.is_tracing()returnstorch._C.is_tracing, the function object, instead of calling thefunction and returning the result.
Test Plan
Continuous integration?
Fixes
This commit fixes #42448.
Differential Revision: D22911062