Skip to content

Support BFloat16 for binary logical operators on CUDA #42485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuhdev wants to merge 9 commits into from
Closed

Support BFloat16 for binary logical operators on CUDA #42485

xuhdev wants to merge 9 commits into from

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Aug 3, 2020 •
edited by ezyang
Loading

Stack from ghstack:

Differential Revision: D23684423

This was referenced Aug 3, 2020
Closed
Closed
@xuhdev xuhdev marked this pull request as draft August 3, 2020 20:56
@dr-ci
Copy link

dr-ci bot commented Aug 3, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 16d2442 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build caffe2_onnx_main_py3_6_clang7_ubuntu16_04_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun) ❄️

Sep 12 03:39:37 fatal: The remote end hung up unexpectedly 
DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/caffe2/py3.6-clang7-ubuntu16.04:376 
 
real	0m24.746s 
user	0m0.092s 
sys	0m0.032s 
Sep 12 03:39:26 ++ export BUILD_ENVIRONMENT=caffe2-onnx-main-py3.6-clang7-ubuntu16.04-build 
Sep 12 03:39:26 ++ BUILD_ENVIRONMENT=caffe2-onnx-main-py3.6-clang7-ubuntu16.04-build 
Sep 12 03:39:26 ++ git submodule sync 
Sep 12 03:39:27 ++ git submodule update -q --init --recursive 
Sep 12 03:39:37 error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function. 
Sep 12 03:39:37 fatal: The remote end hung up unexpectedly 
Sep 12 03:39:37 fatal: early EOF 
Sep 12 03:39:37 fatal: index-pack failed 
Sep 12 03:39:37 fatal: clone of 'https://github.com/eigenteam/eigen-git-mirror.git' into submodule path 'third_party/eigen' failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 28 times.

xuhdev added a commit that referenced this pull request Aug 3, 2020
@xuhdev
Support BFloat16 for binary logical operators on CUDA
0e6b5ef 
ghstack-source-id: 57d8e86
Pull Request resolved: #42485
@xuhdev xuhdev marked this pull request as ready for review August 4, 2020 03:18
@xuhdev xuhdev requested a review from gchanan August 4, 2020 03:18
@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 7, 2020
xuhdev added a commit that referenced this pull request Aug 11, 2020
@xuhdev
Support BFloat16 for binary logical operators on CUDA
79fecda 
ghstack-source-id: 9f93a3e
Pull Request resolved: #42485
@xuhdev xuhdev mentioned this pull request Aug 17, 2020
Closed
@xuhdev xuhdev requested review from ezyang and zasdfgbnm August 18, 2020 23:39
@xuhdev xuhdev mentioned this pull request Aug 25, 2020
Closed
nairbv
nairbv reviewed Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@nairbv nairbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add include_bfloat16=True in torch/testing/init.py get_all_math_dtypes it'll turn on a lot of bfloat16 testing, wherever we currently test for torch.half (e.g. that will turn on all of the cross-dtype testing in test_type_promotion that currently tests torch.half)

@xuhdev
Copy link
Collaborator Author

xuhdev commented Aug 25, 2020

@nairbv logical operators currently don't use get_all_math_dtypes -- it uses get_all_dtypes(), which should have already included bfloat16 for testing.

@mruberry mruberry self-requested a review September 10, 2020 03:40
mruberry
mruberry approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks xuhdev! Looks good now.

@xuhdev xuhdev deleted the gh/xuhdev/83/head branch September 22, 2020 19:11
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 22, 2020

@mruberry merged this pull request in e2b40ce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nairbv nairbv nairbv left review comments

@mruberry mruberry mruberry approved these changes

@gchanan gchanan Awaiting requested review from gchanan

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

@zasdfgbnm zasdfgbnm Awaiting requested review from zasdfgbnm

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xuhdev @facebook-github-bot @nairbv @mruberry @ailzhang @pytorchbot