-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[NNC] Add loop unroll transformation #42465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nickgg ^ |
💊 CI failures summary and remediationsAs of commit 2d97ff6 (more details on the Dr. CI page):
🕵️ 10 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages (reran 10 jobs to discount flakiness):
|
nickgg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @asuhan. Simple and clean, just a few comments:
6c32518 to
3f3f5de
Compare
nickgg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Unroll a loop with constant boundaries, replacing it with multiple instances of the loop body. For example: ``` for x in 0..3: A[x] = x*2 ``` becomes: ``` A[0] = 0 A[1] = 2 A[2] = 4 ```
3f3f5de to
2d97ff6
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Unroll a loop with constant boundaries, replacing it with multiple
instances of the loop body. For example:
becomes: