add Quantizer support to IValue #42438
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 4bae4cd (more details on the Dr. CI page):
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
smessmer
approved these changes
Aug 3, 2020
| static torch::jit::Stack boxArgs(Args... args) { | ||
| // TODO Reuse stack vector instead of allocating? | ||
| torch::jit::Stack stack; | ||
| stack.reserve(sizeof...(Args)); |
Contributor
There was a problem hiding this comment.
Should this reserve be called inside torch::jit::push? Maybe other call sites would benefit from it too.
Author
There was a problem hiding this comment.
True, I can't think of a downside... OTOH I'm not sure I want to colocate that change with the other stuff in this PR 😁
This PR adds IValue support for the `Quantizer` class, by adding a `QuantizerType` tag and associated constructors and destructors. Notes: 1. This eliminates the final type unsupported by our boxed kernel wrappers, so here we also take the opportunity to eliminate the artifacts of our previous incomplete support: a) the special profiling entry points that would box a "can't box" string for unsupported types, and b) the metaprogramming to generate an error-raising wrapper for kernels with `Quantizer` in their signatures. 2. `ConstQuantizerPtr` still has some special logic associated with it in the JIT code, commented as temporary; this PR leaves that undisturbed, but should facilitate its elimination in a followup. Differential Revision: [D22894190](https://our.internmc.facebook.com/intern/diff/D22894190) [ghstack-poisoned]
This PR adds IValue support for the `Quantizer` class, by adding a `QuantizerType` tag and associated constructors and destructors. Notes: 1. This eliminates the final type unsupported by our boxed kernel wrappers, so here we also take the opportunity to eliminate the artifacts of our previous incomplete support: a) the special profiling entry points that would box a "can't box" string for unsupported types, and b) the metaprogramming to generate an error-raising wrapper for kernels with `Quantizer` in their signatures. 2. `ConstQuantizerPtr` still has some special logic associated with it in the JIT code, commented as temporary; this PR leaves that undisturbed, but should facilitate its elimination in a followup. Differential Revision: [D22894190](https://our.internmc.facebook.com/intern/diff/D22894190) [ghstack-poisoned]
This PR adds IValue support for the `Quantizer` class, by adding a `QuantizerType` tag and associated constructors and destructors. Notes: 1. This eliminates the final type unsupported by our boxed kernel wrappers, so here we also take the opportunity to eliminate the artifacts of our previous incomplete support: a) the special profiling entry points that would box a "can't box" string for unsupported types, and b) the metaprogramming to generate an error-raising wrapper for kernels with `Quantizer` in their signatures. 2. `ConstQuantizerPtr` still has some special logic associated with it in the JIT code, commented as temporary; this PR leaves that undisturbed, but should facilitate its elimination in a followup. Differential Revision: [D22894190](https://our.internmc.facebook.com/intern/diff/D22894190) [ghstack-poisoned]
This was referenced Aug 5, 2020
Contributor
This was referenced Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds IValue support for the
Quantizerclass, by adding aQuantizerTypetag and associated constructors and destructors.Notes:
This eliminates the final type unsupported by our boxed kernel wrappers, so here we also take the opportunity to eliminate the artifacts of our previous incomplete support: a) the special profiling entry points that would box a "can't box" string for unsupported types, and b) the metaprogramming to generate an error-raising wrapper for kernels with
Quantizerin their signatures.ConstQuantizerPtrstill has some special logic associated with it in the JIT code, commented as temporary; this PR leaves that undisturbed, but should facilitate its elimination in a followup.Differential Revision: D22894190