[quant] Expose register activation post process hook function to user #42342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 3dccbc0 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 8 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
| # Returning nothing is Ok, Module._call_impl will intrepret this | ||
| # as the pre_hook making no changes to the input, as desired | ||
|
|
||
| def register_activation_post_process_hook(module): |
Contributor
There was a problem hiding this comment.
Can you explain on why this refactoring is needed?
Contributor
Author
There was a problem hiding this comment.
We need to use this function in module definition, see next PR
Contributor
There was a problem hiding this comment.
Sorry, didnt see that before, its clear now.
raghuramank100
approved these changes
Jul 31, 2020
…ion to user" Summary: This is used in #42343 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D22856711](https://our.internmc.facebook.com/intern/diff/D22856711) [ghstack-poisoned]
Contributor
|
This pull request has been merged in c3236b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is used in #42343
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D22856711