Skip to content

Add reduce arg to BCELoss #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soumith merged 3 commits into from
Dec 18, 2017
Merged

Add reduce arg to BCELoss #4231

soumith merged 3 commits into from
Dec 18, 2017

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Dec 18, 2017

See #264 #3532, #4221.

Test Plan

test/run_test.sh

@pytorchbot
Copy link
Collaborator

pytorchbot commented Dec 18, 2017

@zou3519, thanks for your PR! We identified @zdevito to be a potential reviewer.

@onnxbot-worker-1 onnxbot-worker-1 mentioned this pull request Dec 18, 2017
Closed
@soumith soumith merged commit ccf4dc1 into pytorch:master Dec 18, 2017
@zou3519 zou3519 deleted the bceloss-reduce2 branch January 3, 2018 19:50
@soumith soumith added 0.3.1 and removed 0.3.1 labels Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zou3519 @pytorchbot @soumith