Skip to content

[ONNX] Update ONNX export of torch.where to support ByteTensor as input. #42264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spandantiwari wants to merge 3 commits into from
Closed

[ONNX] Update ONNX export of torch.where to support ByteTensor as input. #42264

spandantiwari wants to merge 3 commits into from

Conversation

@spandantiwari
Copy link

@spandantiwari spandantiwari commented Jul 29, 2020

torch.where supports ByteTensor and BoolTensor types for the first input argument (condition predicate). Currently, ONNX exporter assumes that the first argument is BoolTensor. This PR updates the export for torch.where to correctly support export when first argument is a ByteTensor.

@dr-ci
Copy link

dr-ci bot commented Jul 30, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 9530e39 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 16 times.

neginraoof
neginraoof approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

neginraoof
neginraoof reviewed Jul 31, 2020
View reviewed changes
@spandantiwari
Copy link
Author

spandantiwari commented Jul 31, 2020

I will look at the test failure.

@spandantiwari spandantiwari force-pushed the spandantiwari/fix_onnx_where_export branch from bf5bb2e to e15638f Compare August 4, 2020 18:53
@spandantiwari
Copy link
Author

spandantiwari commented Aug 4, 2020

@bzinodev - All the legit test failures are fixed and are passing. Also, rebased the PR. The remaining failures (doc build and test) are unrelated to this PR.

@spandantiwari
Copy link
Author

spandantiwari commented Aug 5, 2020

@bzinodev - I feel that this is ready for your review and merge.

facebook-github-bot
facebook-github-bot reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 7, 2020

@bzinodev merged this pull request in 40ac95d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+1 more reviewer

@neginraoof neginraoof neginraoof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spandantiwari @facebook-github-bot @neginraoof @pytorchbot @mruberry