Skip to content

[CUDA] max_pool2d NCHW performance improvement #42182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xwang233 wants to merge 2 commits into from
Closed

[CUDA] max_pool2d NCHW performance improvement #42182

xwang233 wants to merge 2 commits into from

Conversation

@xwang233
Copy link
Collaborator

@xwang233 xwang233 commented Jul 28, 2020 •
edited
Loading

Fix the regression introduced in #38953.

Please see https://github.com/xwang233/code-snippet/blob/master/max-pool2d-nchw-perf/max-pool2d.ipynb for detailed before & after performance comparisons.

Performance improvement (percentage) for backward max_pool2d before and after this PR (negative value means speed up)

image

Seems like the forward modulo doesn't benefit much from a similar change, so I did not change forward. 1718f0c

@dr-ci
Copy link

dr-ci bot commented Jul 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d221193 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) <confirmed not flaky by 3 failures>

Jul 28 13:02:49 RuntimeError: test_dataloader failed! 
Jul 28 13:02:48 Generated XML report: test-reports/python-unittest/TEST-TestNamedTupleDataLoader-20200728124859.xml 
Jul 28 13:02:48 Generated XML report: test-reports/python-unittest/TEST-TestTensorDataset-20200728124859.xml 
Jul 28 13:02:48 Generated XML report: test-reports/python-unittest/TEST-TestCustomPinFn-20200728124859.xml 
Jul 28 13:02:48 Generated XML report: test-reports/python-unittest/TEST-TestSetAffinity-20200728124859.xml 
Jul 28 13:02:48 Generated XML report: test-reports/python-unittest/TEST-TestStringDataLoader-20200728124859.xml 
Jul 28 13:02:49 Traceback (most recent call last): 
Jul 28 13:02:49   File "test/run_test.py", line 744, in <module> 
Jul 28 13:02:49     main() 
Jul 28 13:02:49   File "test/run_test.py", line 733, in main 
Jul 28 13:02:49     raise RuntimeError(err) 
Jul 28 13:02:49 RuntimeError: test_dataloader failed! 
Jul 28 13:02:49 + cleanup 
Jul 28 13:02:49 + retcode=1 
Jul 28 13:02:49 + set +x

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 9 times.

@xwang233
Copy link
Collaborator Author

xwang233 commented Jul 28, 2020

cc @ptrblck

@xwang233 xwang233 requested a review from ngimel July 28, 2020 19:32
facebook-github-bot
facebook-github-bot reviewed Jul 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2020

@ngimel merged this pull request in fe4f19e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xwang233 @facebook-github-bot @ngimel @pytorchbot @mruberry