Skip to content

Fix flaky NCCL error handling tests. #42149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pritamdamania87 wants to merge 1 commit into from
Closed

Fix flaky NCCL error handling tests. #42149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/distributed/test_c10d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3471,6 +3471,8 @@ def _test_nccl_errors_blocking(self, func):
# aborting nccl communicators before throwing Operation timed out
a = torch.rand(10).cuda(self.rank)
elif self.rank == 1:
# Clean up structures (ex: files for FileStore before going down)
del process_group
func()
else:
# Wait for timeout
Expand Down Expand Up @@ -3552,7 +3554,7 @@ def _wait_for_comm_abort(self, process_group):
return
else:
raise e
time.sleep(1)
time.sleep(0.1)

@requires_nccl()
@skip_if_lt_x_gpu(3)
Expand Down