Skip to content

[ModelLints] Refine dropout lint message. #42046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xcheng16 wants to merge 2 commits into from
Closed

[ModelLints] Refine dropout lint message. #42046

xcheng16 wants to merge 2 commits into from

Conversation

@xcheng16
Copy link
Contributor

@xcheng16 xcheng16 commented Jul 24, 2020 •
edited
Loading

Stack from ghstack:

Refine dropout lint message as we have enabled dropout operator removal in optimize_for_mobile method.

Differential Revision: D22741132

@xcheng16
[ModelLints] Refine dropout lint message.
e42da56 
Refine dropout lint message as we have enabled dropout operator removal in optimize_for_mobile method.

Differential Revision: [D22741132](https://our.internmc.facebook.com/intern/diff/D22741132/)

[ghstack-poisoned]
xcheng16 added a commit that referenced this pull request Jul 24, 2020
@xcheng16
[ModelLints] Refine dropout lint message.
dbca237 
Refine dropout lint message as we have enabled dropout operator removal in optimize_for_mobile method.

Differential Revision: [D22741132](https://our.internmc.facebook.com/intern/diff/D22741132/)

ghstack-source-id: 108491640
Pull Request resolved: #42046
@dr-ci
Copy link

dr-ci bot commented Jul 24, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit f301755 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build caffe2_onnx_main_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jul 27 22:46:19 E AssertionError: False is not true 
Jul 27 22:46:19         worker_coordinator = parallel_workers.init_workers(dummy_worker) 
Jul 27 22:46:19         worker_coordinator.start() 
Jul 27 22:46:19      
Jul 27 22:46:19         for _ in range(10): 
Jul 27 22:46:19             value = dequeue_value(queue) 
Jul 27 22:46:19             self.assertTrue( 
Jul 27 22:46:19                 value in [b'0', b'1'], 'Got unexpected value ' + str(value) 
Jul 27 22:46:19             ) 
Jul 27 22:46:19      
Jul 27 22:46:19 >       self.assertTrue(worker_coordinator.stop()) 
Jul 27 22:46:19 E       AssertionError: False is not true 
Jul 27 22:46:19  
Jul 27 22:46:19 ../.local/lib/python3.6/site-packages/caffe2/python/parallel_workers_test.py:73: AssertionError 
Jul 27 22:46:19 ----------------------------- Captured stdout call ----------------------------- 
Jul 27 22:46:19 Wait for workers to die: train 
Jul 27 22:46:19 Worker <Thread(parallel_workers worker id 1, started daemon 140390988502784)> failed to close while waiting 
Jul 27 22:46:19 All workers terminated: False 
Jul 27 22:46:19 - generated xml file: /var/lib/jenkins/workspace/caffe2_tests/python/result.xml - 
Jul 27 22:46:19 ---------- onnx coverage: ---------- 
Jul 27 22:46:19 Operators (passed/loaded/total): 0/0/185 
Jul 27 22:46:19 ------------------------------------
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@xcheng16
Update on "[ModelLints] Refine dropout lint message."
f301755 
Refine dropout lint message as we have enabled dropout operator removal in optimize_for_mobile method.

Differential Revision: [D22741132](https://our.internmc.facebook.com/intern/diff/D22741132/)

[ghstack-poisoned]
xcheng16 added a commit that referenced this pull request Jul 27, 2020
@xcheng16
[ModelLints] Refine dropout lint message.
951d010 
Pull Request resolved: #42046

Refine dropout lint message as we have enabled dropout operator removal in optimize_for_mobile method.
ghstack-source-id: 108607182

Differential Revision: [D22741132](https://our.internmc.facebook.com/intern/diff/D22741132/)
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2020

This pull request has been merged in bcd75bd.

@facebook-github-bot facebook-github-bot deleted the gh/xcheng16/31/head branch July 31, 2020 14:18
@peterjc123 peterjc123 mentioned this pull request Aug 2, 2020
Closed
@SplitInfinity SplitInfinity mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xcheng16 @facebook-github-bot @mruberry