Add done() API to Future #42013
Closed
Add done() API to Future #42013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
mrshenli
requested review from
apaszke,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: jit
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 716aefd (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
Contributor
Author
|
|
Differential Revision: [D22729596](https://our.internmc.facebook.com/intern/diff/D22729596) [ghstack-poisoned]
Differential Revision: [D22729596](https://our.internmc.facebook.com/intern/diff/D22729596) [ghstack-poisoned]
mrshenli
commented
Jul 24, 2020
rohan-varma
approved these changes
Jul 24, 2020
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
LGTM! For the annotation, is there any way to test/validate it (such as running mypy typechecker)?
Contributor
Author
I believe there are tests to cover this. The first version caused test failures, as I was using |
pbelevich
approved these changes
Jul 24, 2020
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D22729596