Implement scatter reductions (CUDA), remove divide/subtract #41977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit d6dd7b0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 68 times. |
rgommers
changed the title
ngimel
added
the
triaged
ngimel
reviewed
Jul 31, 2020
Collaborator
|
xla error is real, can you please skip part of the test checking for runtime error on xla? Also, rocm build interestingly times out on scatter test, so it's hard to say if it's related or not. |
Collaborator
|
Hm, rocm build times out on a scatter test, that's worrying. Can you disable it on rocm? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
OK everything passing except the facebook internal tests. |
ngimel
approved these changes
Sep 17, 2020
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Fixes #33394 . This PR does two things: 1. Implement CUDA scatter reductions with revamped GPU atomic operations. 2. Remove support for divide and subtract for CPU reduction as was discussed with ngimel . I've also updated the docs to reflect the existence of only multiply and add. Pull Request resolved: #41977 Reviewed By: mruberry Differential Revision: D23748888 Pulled By: ngimel fbshipit-source-id: ea643c0da03c9058e433de96db02b503514c4e9c
Contributor
|
Why changes to submodules were pulled as part of this PR? (namely, it reverted #44706) |
malfet
pushed a commit
to malfet/pytorch
that referenced
this pull request
Sep 18, 2020
Summary:
- Bump oneDNN (mkl-dnn) to 1.6 for bug fixes
- Fixes pytorch#42446. RuntimeError: label is redefined for convolutions with large filter size on Intel AVX512
- Implemented workaround for internal compiler error when building oneDNN with Microsoft Visual Studio 2019 (pytorch#43169)
Restore pytorch#44706 which was reverted by pytorch#41977
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 19, 2020
Summary: Restore #44706, which should workaround VC compiler crash, which was reverted by #41977 Update configs to use ":stable" Windows images Pull Request resolved: #44746 Reviewed By: walterddr Differential Revision: D23793682 Pulled By: malfet fbshipit-source-id: bfdc36c35b920f58798a18c15642ec7efc68f00e
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 19, 2020
|
Is there an option to ignore/sum over several of the output dimensions? |
mikaylagawarecki
added a commit
that referenced
this pull request
Mar 23, 2022
Noticed that `cuda_atomic_ops_test` wasn't added to `run_test.sh` and hence hasn't been running in CI since it was added in #41977. [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Mar 24, 2022
Noticed that `cuda_atomic_ops_test` wasn't added to `run_test.sh` and hence hasn't been running in CI since it was added in #41977. [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Mar 24, 2022
Noticed that `cuda_atomic_ops_test` wasn't added to `run_test.sh` and hence hasn't been running in CI since it was added in #41977. [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Mar 24, 2022
Noticed that `cuda_atomic_ops_test` wasn't added to `run_test.sh` and hence hasn't been running in CI since it was added in #41977. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33394 .
This PR does two things:
I've also updated the docs to reflect the existence of only multiply and add.