Fix ASAN error in QNNPACK's integration of qlinear_dynamic. #41967
Conversation
[ghstack-poisoned]
|
|
||
| auto bias_contig = bias_vec.contiguous(); | ||
| auto bias_contig = at::native::xnnpack::internal::allocate_padded_contiguous_if_needed( | ||
| bias_, bias_.suggest_memory_format()); |
There was a problem hiding this comment.
This is the least intrusive fix I could think of that solves this issue and checks the performance boxes (no reallocation on mobile), but is ugly in that it's adding a header dependency on XNNPACK integration. Ideally we would want that file to be in a common location. Do you want me to address that here or in a separate commit (or hopefully someone else can refactor this since I need to spend some time on GPU.)
There was a problem hiding this comment.
Also technically this causes an extra allocation on non-mobile builds if the number of output channels is already a multiple of 8 in which case a reallocation is not needed.
Differential Revision: [D22715307](https://our.internmc.facebook.com/intern/diff/D22715307) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit dace6f0 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
|
@AshkanAliabadi merged this pull request in 6a09df9. |
Stack from ghstack:
Differential Revision: D22715307