Make fmod work with zero divisors consistently #41948
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbell10
approved these changes
Jul 23, 2020
Collaborator
peterbell10
left a comment
peterbell10
left a comment
There was a problem hiding this comment.
A couple nits but overall looks good. The scalar kernel must have been overlooked in #38919.
xuhdev
force-pushed
the
fmod-zero
branch
2 times, most recently
from
6e19bc6 to
24c40f2
Compare
Currently `torch.tensor(1, dtype=torch.int).fmod(0)` crashes (floating point exception). This PR should fix this issues.
💊 CI failures summary and remediationsAs of commit 95a921a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Collaborator
Author
|
@peterbell10 I've updated. Is this ready to merge? |
Collaborator
Author
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jul 27, 2020
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
torch.tensor(1, dtype=torch.int).fmod(0)crashes (floating point exception).This PR should fix this issue.