Skip to content

check pruned attributes before deleting #41913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyyever wants to merge 1 commit into from
Closed

check pruned attributes before deleting #41913

cyyever wants to merge 1 commit into from

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Jul 23, 2020

I copyed a pruned model after deleteing the derived tensors. In order to be able to reparameter the model, we should check the existence of the tensors here.

@cyyever cyyever requested a review from apaszke as a code owner July 23, 2020 09:56
@cyyever cyyever changed the title check attr before deleting check pruned attributes before deleting Jul 23, 2020
@dr-ci
Copy link

dr-ci bot commented Jul 23, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4962ffb (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build caffe2_onnx_ort2_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jul 23 10:23:05 E AssertionError: False is not true 
Jul 23 10:23:05         worker_coordinator = parallel_workers.init_workers(dummy_worker) 
Jul 23 10:23:05         worker_coordinator.start() 
Jul 23 10:23:05      
Jul 23 10:23:05         for _ in range(10): 
Jul 23 10:23:05             value = dequeue_value(queue) 
Jul 23 10:23:05             self.assertTrue( 
Jul 23 10:23:05                 value in [b'0', b'1'], 'Got unexpected value ' + str(value) 
Jul 23 10:23:05             ) 
Jul 23 10:23:05      
Jul 23 10:23:05 >       self.assertTrue(worker_coordinator.stop()) 
Jul 23 10:23:05 E       AssertionError: False is not true 
Jul 23 10:23:05  
Jul 23 10:23:05 ../.local/lib/python3.6/site-packages/caffe2/python/parallel_workers_test.py:73: AssertionError 
Jul 23 10:23:05 ----------------------------- Captured stdout call ----------------------------- 
Jul 23 10:23:05 Wait for workers to die: train 
Jul 23 10:23:05 Worker <Thread(parallel_workers worker id 0, started daemon 139882966009600)> failed to close while waiting 
Jul 23 10:23:05 Worker <Thread(parallel_workers worker id 1, started daemon 139882974402304)> failed to close while waiting 
Jul 23 10:23:05 All workers terminated: False 
Jul 23 10:23:05 - generated xml file: /var/lib/jenkins/workspace/caffe2_tests/python/result.xml - 
Jul 23 10:23:05 ---------- onnx coverage: ---------- 
Jul 23 10:23:05 Operators (passed/loaded/total): 0/0/185
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

mrshenli
mrshenli approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

facebook-github-bot
facebook-github-bot reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2020

@mrshenli merged this pull request in c5fdcd8.

@cyyever cyyever mentioned this pull request Jul 24, 2020
Closed
@cyyever cyyever deleted the fix_prune branch August 31, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mrshenli mrshenli mrshenli approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @facebook-github-bot @mrshenli @pytorchbot @mruberry