Enables torch.full bool and integer type inference #41912
Conversation
💊 CI failures summary and remediationsAs of commit 0e7cd64 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
| ScalarType::ComplexFloat; | ||
| return options.dtype(scalar_type); | ||
| } else { | ||
| return options.dtype(get_default_dtype()); |
There was a problem hiding this comment.
do you need to do this? Presumably it was working before without this?
There was a problem hiding this comment.
It did and we could safely leave this out. I included it for consistency and readability.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mruberry |
|
Thanks @albanD! Darn merge conflicts. |
…le_full_dtype_inference
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
After being deprecated in 1.5 and throwing a runtime error in 1.6, we can now enable torch.full inferring its dtype when given bool and integer fill values. This PR enables that inference and updates the tests and docs to reflect this.