Skip to content

[ONNX] Export KLDivLoss #41858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
neginraoof wants to merge 16 commits into from
Closed

[ONNX] Export KLDivLoss #41858

neginraoof wants to merge 16 commits into from

Conversation

@neginraoof
Copy link
Contributor

@neginraoof neginraoof commented Jul 22, 2020

Enable export for KLDivLoss

@dr-ci
Copy link

dr-ci bot commented Jul 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 9fdb633 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 42 times.

@neginraoof neginraoof changed the title [ONNX] Expor KLDivLoss [ONNX] Export KLDivLoss Jul 22, 2020
@mrshenli mrshenli requested a review from houseroad July 23, 2020 19:42
@mrshenli mrshenli added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jul 23, 2020
@neginraoof neginraoof requested a review from BowenBao July 23, 2020 22:23
spandantiwari
spandantiwari reviewed Jul 29, 2020
View reviewed changes
spandantiwari
spandantiwari reviewed Jul 29, 2020
View reviewed changes
spandantiwari
spandantiwari reviewed Jul 29, 2020
View reviewed changes
spandantiwari
spandantiwari approved these changes Jul 30, 2020
View reviewed changes
Copy link

@spandantiwari spandantiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we update the helper method names from _kl_div_log_target to _kl_div_log_target_impl?

@neginraoof
Copy link
Contributor Author

neginraoof commented Jul 31, 2020 •
edited
Loading

@spandantiwari

LGTM. Can we update the helper method names from _kl_div_log_target to _kl_div_log_target_impl?

Yes, this is done already. Thanks.

facebook-github-bot
facebook-github-bot reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Merge branch 'master' of https://github.com/pytorch/pytorch into nera…
6d28da6 
…oof/kldiv

# Conflicts:
#	torch/onnx/symbolic_opset9.py
@neginraoof
Merge branch 'neraoof/kldiv' of github.com:neginraoof/pytorch into ne…
84d6829 
…raoof/kldiv

# Conflicts:
#	torch/onnx/symbolic_opset9.py
@neginraoof
flake8 fix
4060db8
facebook-github-bot
facebook-github-bot reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

neginraoof commented Aug 11, 2020 •
edited
Loading

@bzinodev Is there any related issue with tests or anything blocking merge?
Please let me know if there's anything I need to fix here, thanks.

facebook-github-bot
facebook-github-bot reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

neginraoof commented Aug 21, 2020 •
edited
Loading

@bzinodev please let me know if you see any related failures for the internal job.

@neginraoof
Copy link
Contributor Author

neginraoof commented Aug 25, 2020

@bzinodev Can we merge this PR?

facebook-github-bot
facebook-github-bot reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@neginraoof
Copy link
Contributor Author

neginraoof commented Sep 1, 2020 •
edited
Loading

@bzinodev CI is green. Would you please help merge this PR? Thanks!

@neginraoof
Copy link
Contributor Author

neginraoof commented Sep 2, 2020

@bzinodev
CI is green. Would you please help merge this PR? Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 2, 2020

@bzinodev merged this pull request in f6f9d22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad Awaiting requested review from houseroad

@BowenBao BowenBao Awaiting requested review from BowenBao

+2 more reviewers

@spandantiwari spandantiwari spandantiwari approved these changes

@bzinodev bzinodev bzinodev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@neginraoof @facebook-github-bot @spandantiwari @bzinodev @mrshenli @pytorchbot @mruberry