Skip to content

Fix docstring in Unflatten #41835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alvgaona wants to merge 2 commits into from
Closed

Fix docstring in Unflatten #41835

alvgaona wants to merge 2 commits into from

Conversation

@alvgaona
Copy link
Contributor

@alvgaona alvgaona commented Jul 22, 2020

I'd like to amend the docstring introduced in #41564. It's not rendering correctly on the web, and this should fix it.

cc @albanD

@alvgaona alvgaona requested a review from apaszke as a code owner July 22, 2020 02:28
@dr-ci
Copy link

dr-ci bot commented Jul 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ffc8188 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@albanD
Copy link
Collaborator

albanD commented Jul 22, 2020

Thanks for the update. Did you try these changes locally to make sure they render as expected?

@alvgaona
Copy link
Contributor Author

alvgaona commented Jul 22, 2020

Hi, Alban.

Yes. Here it is.

image

albanD
albanD approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome,
Thanks!

facebook-github-bot
facebook-github-bot reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@alvgaona
Copy link
Contributor Author

alvgaona commented Jul 23, 2020

@albanD how can I rerun pr/pytorch-linux-xenial-rocm3.5.1-py3.6?

@albanD
Copy link
Collaborator

albanD commented Jul 23, 2020

You just ask :D

@albanD
Copy link
Collaborator

albanD commented Jul 23, 2020

@pytorchbot retest this please.

@alvgaona
Copy link
Contributor Author

alvgaona commented Jul 23, 2020

Thanks!

@alvgaona
Copy link
Contributor Author

alvgaona commented Jul 23, 2020 •
edited
Loading

Does this PR need the merged label to update pytorch.org?

@albanD
Copy link
Collaborator

albanD commented Jul 23, 2020

No it was merged properly.
But I think we only update the doc here every night. So it should be up tomorrow morning.

@albanD albanD mentioned this pull request Jul 23, 2020
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2020

@albanD merged this pull request in 37e7f0c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@albanD albanD albanD approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alvgaona @albanD @facebook-github-bot @pytorchbot @mruberry