Don't materialize output grads #41821
Conversation
heitorschueroff
requested review from
albanD,
apaszke,
ebetica,
goldsborough and
yf225
as code owners
|
I'm working on the doc but wanted feedback on the code in case we decide to change directions. |
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
I think the API is good.
Mostly style questions below.
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Looks good!
Thanks for updating the doc!
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 38c4660 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 23 times. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@heitorschueroff merged this pull request in ffc3da3. |
albanD
added
module: bc-breaking
5 participants
Added a new option in AutogradContext to tell autograd to not materialize output grad tensors, that is, don't expand undefined/None tensors into tensors full of zeros before passing them as input to the backward function.
This PR is the second part that closes #41359. The first PR is #41490.