Fix a bug where from_dlpack fails if cuda is not initialized. #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdevito
force-pushed
the
pr/explicit-init-function
branch
from
a3a0219 to
c8ca4d5
Compare
soumith
approved these changes
Dec 14, 2017
apaszke
reviewed
Dec 14, 2017
| // so if we have a cuda tensor, then we need to make sure | ||
| // we have called _lazy_init here | ||
| if(atensor.is_cuda()) { | ||
| py::module::import("torch.cuda").attr("init")(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Dec 15, 2017
| def test_dlpack_cuda(self): | ||
| x = torch.randn(1, 2, 3, 4).cuda() | ||
| z = from_dlpack(to_dlpack(x)) | ||
| self.assertEqual(z, x) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.