Skip to content

Raise RuntimeError for zero stride pooling #41819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xwang233 wants to merge 5 commits into from
Closed

Raise RuntimeError for zero stride pooling #41819

xwang233 wants to merge 5 commits into from

Conversation

@xwang233
Copy link
Collaborator

@xwang233 xwang233 commented Jul 21, 2020

Close #41767

@xwang233 xwang233 requested a review from apaszke as a code owner July 21, 2020 21:58
@dr-ci
Copy link

dr-ci bot commented Jul 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 243c642 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

lDCgcLet9oftQr8KCEYIIZ0%2F%2FzI378Lfa%2FKh1K%2BnWdufjhInOKcorcG98OK8fS05T9qqA8sFWJDOEbNvIzwzl0QulYG06JVG0pWH%2Bt5O9grJIY9Bd5v9a7%2FDFsNw4fmp7LiBp%2FjuIxJz7Hao%2BIasAdxUBeus4lJ%2FFW7zBVwNoXJywHLyiho%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20200722T031427Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=ASIAYTIFIPBEK3IXPOXW%2F20200722%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=c817de52746ddd2e710941acb0a2266e980ffca2bd04ec5dedb7d8e1b3b14e28: net/http: TLS handshake timeout 
DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-py3.6-gcc7:ab1632df-fa59-40e6-8c23-98e004f61148-bazel-243c6423aa2c2ed78d8a6bb80bdd095b91eeb143 
DCgcLet9oftQr8KCEYIIZ0%2F%2FzI378Lfa%2FKh1K%2BnWdufjhInOKcorcG98OK8fS05T9qqA8sFWJDOEbNvIzwzl0QulYG06JVG0pWH%2Bt5O9grJIY9Bd5v9a7%2FDFsNw4fmp7LiBp%2FjuIxJz7Hao%2BIasAdxUBeus4lJ%2FFW7zBVwNoXJywHLyiho%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20200722T031427Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=ASIAYTIFIPBEK3IXPOXW%2F20200722%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=c817de52746ddd2e710941acb0a2266e980ffca2bd04ec5dedb7d8e1b3b14e28: net/http: TLS handshake timeout
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@xwang233
Copy link
Collaborator Author

xwang233 commented Jul 21, 2020

cc @ptrblck

@xwang233 xwang233 requested a review from ngimel July 21, 2020 21:59
@mrshenli mrshenli added module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jul 23, 2020
facebook-github-bot
facebook-github-bot reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2020

@ngimel merged this pull request in b0424a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.nn.functional.avg_pool2d has floating point exception when stride is 0

6 participants

@xwang233 @facebook-github-bot @ngimel @mrshenli @pytorchbot @mruberry