-
Notifications
You must be signed in to change notification settings - Fork 26.3k
replace the white list from default mappings #41802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 67b4e00 (more details on the Dr. CI page):
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 25 times. |
|
Please, rebase :) |
z-a-f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will recheck after rebase
365a2d3 to
c6beaa3
Compare
|
@z-a-f rebase has been done |
ce24eb0 to
baff294
Compare
|
@z-a-f rebased again to since one CI was failing due to base env. |
baff294 to
b0467ae
Compare
|
Resolved new conflicts and rebased |
b0467ae to
d072182
Compare
|
Rebased again to resolve conflicts |
malfet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've forgot to rename the argument name
Also, you still have the merge conflicts (please feel free to post git commands you are using to rebase your change here)
@malfet This PR was for the issue 41756 relating to default_mappings.py, I presumed that it should only be related to it. Thanks for the feedback will update the argument and its usage. Regarding the rebase steps, please find the history of git commands used in this branch, Please let me know if any more information is required. // second time rebasing for new conflicts, usually below are the steps for rebasing |
aa78c8f to
756c1ac
Compare
|
LGTM, will leave to @malfet for landing |
z-a-f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
756c1ac to
67b4e00
Compare
|
Rebased to double check the PR changes |
Codecov Report
@@ Coverage Diff @@
## master #41802 +/- ##
=========================================
Coverage ? 69.35%
=========================================
Files ? 381
Lines ? 47321
Branches ? 0
=========================================
Hits ? 32821
Misses ? 14500
Partials ? 0 Continue to review full report at Codecov.
|
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Replaced "whitelist" from default_mappings.py
Fixes #41756