Skip to content

Conversation

@agniutkarsh
Copy link
Contributor

closes #41749

Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, what's the motivation? And why not combine those PRs together.

@zhangguanheng66 zhangguanheng66 added module: tests Issues related to tests (not the torch.testing module) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jul 21, 2020
@SplitInfinity
Copy link

The motivation is in #41443. I intentionally requested that these changes be made as small as possible because this is not a giant find-and-replace exercise. Some of the variables, functions, and flags that are being renamed in this process are used elsewhere within FB, but I personally don't know which ones. A large diff that attempts to replace several instances at once might have to wait on some internal changes, then encounter rebase/merge problems due to being stale, etc. I think it's easier to make many small, targetted changes.

@SplitInfinity SplitInfinity requested a review from zasdfgbnm July 21, 2020 18:42
@SplitInfinity
Copy link

Moreover, I did not expect so many people to take on these tasks so quickly. I created these issues primarily for my own tracking because I thought I was the only one who would want to do this work.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in d198fb3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: tests Issues related to tests (not the torch.testing module) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace blacklist/whitelist in test/test_namedtuple_return_api.py

7 participants