Skip to content

Conversation

@jeongukjae
Copy link
Contributor

  • add _LRScheduler.get_last_lr type stub.
  • remove CosineAnnealingWarmRestarts.step because its signature is same with _LRScheduler's.

* add _LRScheduler::get_last_lr type stub.
* remove CosineAnnealingWarmRestarts::step because _LRScheduler has same typing interface.
@zhangguanheng66 zhangguanheng66 added module: optimizer Related to torch.optim triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jul 21, 2020
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentqb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vincentqb merged this pull request in e831299.

@jeongukjae jeongukjae deleted the fix-lr-scheduler-type-error branch July 24, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: optimizer Related to torch.optim open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants