Skip to content

Change whitelist to allow in file test_quantized_op.py #41771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kenjihiraoka wants to merge 3 commits into from
Closed

Change whitelist to allow in file test_quantized_op.py #41771

kenjihiraoka wants to merge 3 commits into from

Conversation

@kenjihiraoka
Copy link
Contributor

@kenjihiraoka kenjihiraoka commented Jul 21, 2020 •
edited by SplitInfinity
Loading

Fixes #41751

@kenjihiraoka kenjihiraoka changed the title Change whitelist to allowlist in file test_quantized_op.py Change whitelist to allow in file test_quantized_op.py Jul 21, 2020
@dr-ci
Copy link

dr-ci bot commented Jul 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3925482 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@SplitInfinity SplitInfinity requested review from vkuzo and z-a-f July 21, 2020 03:17
@SplitInfinity SplitInfinity added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 21, 2020
facebook-github-bot
facebook-github-bot reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

z-a-f
z-a-f approved these changes Jul 21, 2020
View reviewed changes
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenjihiraoka
Copy link
Contributor Author

kenjihiraoka commented Jul 21, 2020

@SplitInfinity do i need to do something for these failed build/tests?

@SplitInfinity
Copy link

SplitInfinity commented Jul 21, 2020

@kenjihiraoka No. I'll merge this. Thanks for working on it!

@kenjihiraoka
Copy link
Contributor Author

kenjihiraoka commented Jul 21, 2020

Nice, I appreciate the opportunity to contribute 😄

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2020

@SplitInfinity merged this pull request in 46808b4.

@kenjihiraoka kenjihiraoka deleted the issue-41443-test_quantized_op branch July 21, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@vkuzo vkuzo vkuzo approved these changes

+1 more reviewer

@z-a-f z-a-f z-a-f approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace blacklist/whitelist in test/quantization/test_quantized_op.py

7 participants

@kenjihiraoka @SplitInfinity @facebook-github-bot @vkuzo @z-a-f @pytorchbot @mruberry