Skip to content

[Gloo] GPU alltoall #41690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jiayisuse wants to merge 1 commit into from
Closed

[Gloo] GPU alltoall #41690

jiayisuse wants to merge 1 commit into from

Conversation

@jiayisuse
Copy link
Contributor

@jiayisuse jiayisuse commented Jul 20, 2020

Summary: Gloo alltoall for GPU

Test Plan: buck test mode/dev-nosan caffe2/torch/lib/c10d:ProcessGroupGlooTest

Differential Revision: D22631554

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 20, 2020

This pull request was exported from Phabricator. Differential Revision: D22631554

rohan-varma
rohan-varma reviewed Jul 20, 2020
View reviewed changes
torch/lib/c10d/ProcessGroupGloo.cpp Outdated
Copy link
Contributor

@rohan-varma rohan-varma Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would these be better named cpuInput/cpuOutput to reflect that they are CPU tensors?

@jiayisuse @facebook-github-bot
GLOO process group GPU alltoall (pytorch#41690)
0ccbfa1 
Summary:
Pull Request resolved: pytorch#41690

Gloo alltoall for GPU

Test Plan: buck test mode/dev-nosan caffe2/torch/lib/c10d:ProcessGroupGlooTest

Reviewed By: osalpekar

Differential Revision: D22631554

fbshipit-source-id: 22a4e132741cdd9e7ac69f7c816e1339ae47dce9
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 20, 2020

This pull request was exported from Phabricator. Differential Revision: D22631554

@dr-ci
Copy link

dr-ci bot commented Jul 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0ccbfa1 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

E: Failed to fetch http://us-east-1.ec2.archive.ubuntu.com/ubuntu/dists/xenial-updates/main/i18n/Translation-en.xz Hash Sum mismatch 
 87% [Working]               Hit:35 https://packagecloud.io/circleci/trusty/ubuntu xenial/main Sources 
                           87% [Working]               Hit:36 https://packagecloud.io/circleci/trusty/ubuntu xenial/main amd64 Packages 
                            88% [Working]               Hit:38 https://packagecloud.io/circleci/trusty/ubuntu xenial/main all Packages 
                            88% [Working]               Fetched 5,229 kB in 3s (1,715 kB/s) 
Reading package lists... 99%  Reading package lists... Done  
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://cli-assets.heroku.com/apt ./ InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
W: The repository 'https://packagecloud.io/circleci/trusty/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: Failed to fetch https://cli-assets.heroku.com/apt/./InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
E: Failed to fetch http://us-east-1.ec2.archive.ubuntu.com/ubuntu/dists/xenial-updates/main/i18n/Translation-en.xz  Hash Sum mismatch 
W: Some index files failed to download. They have been ignored, or old ones used instead.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2020

This pull request has been merged in 65bd381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli Awaiting requested review from mrshenli

@pietern pietern Awaiting requested review from pietern

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

1 more reviewer

@rohan-varma rohan-varma rohan-varma left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiayisuse @facebook-github-bot @rohan-varma @mruberry