Skip to content

replaced blacklist with blocklist in test/test_type_hints.py #41644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ari-hacks wants to merge 1 commit into from
Closed

replaced blacklist with blocklist in test/test_type_hints.py #41644

ari-hacks wants to merge 1 commit into from

Conversation

@ari-hacks
Copy link
Contributor

@ari-hacks ari-hacks commented Jul 19, 2020 •
edited by SplitInfinity
Loading

Fixes #41719.

@ari-hacks ari-hacks mentioned this pull request Jul 19, 2020
Closed
64 tasks
@gchanan gchanan requested a review from zou3519 July 21, 2020 01:31
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 21, 2020
zou3519
zou3519 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

facebook-github-bot
facebook-github-bot reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@SplitInfinity SplitInfinity mentioned this pull request Jul 21, 2020
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2020

@zou3519 merged this pull request in 341c404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace blacklist/whitelist in test/test_type_hints.py

6 participants

@ari-hacks @facebook-github-bot @zou3519 @gchanan @pytorchbot @mruberry