@vincentqb Since I'm not a Facebook employee, is it possible to find out what caused the warning during internal tests so I can fix it. Don't know if these tests are just ordinary tests from this repo, or there are additionional tests on top of that. This PR is relatively small, so I didn't build it from source and run tests, since I'm working on Windows and building from source seems a bit tricky (probably should use Linux for this sort of development in the future).

Hey,

It seems like the tests for botorch gets broken by this change. In particular, they actually use duplicated parameters in their test suite.
We should double check with them if this is on purpose or not. And what is the behavior they expect.

If it is just an oversight on their side. A simple way to move forward is to make the error a warning stating that this will become an error in future versions.
You can also link to the issue in the warning for people that want more details of why it is ambiguous to do it.

Will do.

💊 CI failures summary and remediations

As of commit f1c6235 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

@albanD @vincentqb Replaced the error with a warning.

@albanD @vincentqb Not sure what breaks the tests now. If it's related to third party modules, when I fetched from the master to be up to date (before making my changes), I forgot to update submodules so I can push that fully updated version of the branch if you think it can solve the issue.

The errors showing up internally are now unrelated. I'm trying to land the diff again.

@vincentqb merged this pull request in 4281240.