-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Verbose param for schedulers that don't have it #38726 #41580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @vincentqb |
|
Awesome, thanks! Just in case someone was using the keyword parameters as positional, can you make verbose the last parameter |
💊 CI failures summary and remediationsAs of commit aa2fdeb (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
Hi @vincentqb, thanks for your patience! |
vincentqb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentqb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@vincentqb merged this pull request in 17f76f9. |
Verbose param for schedulers that don't have it #38726