Skip to content

Conversation

@guol-fnst
Copy link
Contributor

Verbose param for schedulers that don't have it #38726

@guol-fnst
Copy link
Contributor Author

Hi @vincentqb
Since this issue(#38726) have not been fixed for months, so I'm trying to work on it.
Could you please help to review this PR?
Much appreciate!

@zou3519 zou3519 requested a review from vincentqb July 17, 2020 15:47
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 17, 2020
@vincentqb
Copy link
Contributor

Awesome, thanks! Just in case someone was using the keyword parameters as positional, can you make verbose the last parameter __init__?

@dr-ci
Copy link

dr-ci bot commented Jul 20, 2020

💊 CI failures summary and remediations

As of commit aa2fdeb (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_windows_vs2019_py36_cpu_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun) ❄️

CondaHTTPError: HTTP 000 CONNECTION FAILED for url
 
circleci@PACKER-5F0EEC92 C:\Users\circleci\project>call C:\Jenkins\Miniconda3\Scripts\activate.bat C:\Jenkins\Miniconda3  
 
(base) circleci@PACKER-5F0EEC92 C:\Users\circleci\project>if "" == "" ( 
call conda install -y -q python=3.6 numpy cffi pyyaml boto3   
 call conda install -y -q -c conda-forge cmake  
)  
Collecting package metadata (current_repodata.json): ...working... done 
Solving environment: ...working... done 
 
CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://repo.anaconda.com/pkgs/main/win-64/mkl-2020.1-216.conda> 
Elapsed: - 
 
An HTTP error occurred when trying to retrieve this URL. 
HTTP errors are often intermittent, and a simple retry will get you on your way. 
 
 
 
## Package Plan ## 
 
  environment location: C:\Jenkins\Miniconda3 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@guol-fnst
Copy link
Contributor Author

Awesome, thanks! Just in case someone was using the keyword parameters as positional, can you make verbose the last parameter __init__?

Hi @vincentqb, thanks for your patience!
I have modified the code, any other advice?

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentqb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vincentqb merged this pull request in 17f76f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants