-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[ONNX] Export static as_strided #41569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 87b4bd3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
neginraoof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM.
|
Can you explain more about the second case not supported? Maybe with an example? Also, it might be helpful to add brief comments about unsupported scenarios in the symbolic file. For future reference. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
as_stridedcreates a view of an existing tensor with specifiedsizes,strides, andstorage_offsets. This PR supports the export ofas_stridedwith static argumentstrides. The following scenarios will not be supported:as_stridedoutput, and vice versa.