Skip to content

Conversation

@BowenBao
Copy link
Collaborator

as_strided creates a view of an existing tensor with specified sizes, strides, and storage_offsets. This PR supports the export of as_strided with static argument strides. The following scenarios will not be supported:

  • Calling on tensor of dynamic shape, i.e. the tensor shape differs between model runs and different model inputs.
  • In-place operations, i.e. updates to the original tensor that are expected to reflect in the as_strided output, and vice versa.

@dr-ci
Copy link

dr-ci bot commented Jul 17, 2020

💊 CI failures summary and remediations

As of commit 87b4bd3 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@zou3519 zou3519 requested a review from houseroad July 17, 2020 15:41
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 17, 2020
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM.

@neginraoof
Copy link
Contributor

Can you explain more about the second case not supported? Maybe with an example?
Is this a case where there is an inplace operation right before as_strided?

Also, it might be helpful to add brief comments about unsupported scenarios in the symbolic file. For future reference.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 1b18adb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants