Skip to content

Makes the use of the term "module" consistent through the serialization note #41563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mruberry wants to merge 2 commits into from
Closed

Makes the use of the term "module" consistent through the serialization note #41563

mruberry wants to merge 2 commits into from

Conversation

@mruberry
Copy link
Collaborator

@mruberry mruberry commented Jul 16, 2020

module -> torch.nn.Module or ScriptModule, as appropriate. + bonus grammar fix.

@mruberry mruberry requested a review from gchanan July 16, 2020 21:42
facebook-github-bot
facebook-github-bot reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry mruberry deleted the more_doc_fixes branch July 16, 2020 22:26
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 16, 2020

@mruberry merged this pull request in a0e5899.

@dr-ci
Copy link

dr-ci bot commented Jul 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 5d73eb7 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 2 failures tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (1/2)

Step: "Checkout code" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: couldn't find remote ref more_doc_fixes 
Using SSH Config Dir /home/circleci/.ssh 
Cloning into '.'... 
Warning: Permanently added the RSA host key for IP address '140.82.113.4' to the list of known hosts.  
remote: Enumerating objects: 404573         remote: Enumerating objects: 3              remote: Enumerating objects: 104, done.         
remote: Counting objects:  98% (102/104)         remote: Counting objects:  99% (103/104)         remote: Counting objects: 100% (104/104)         remote: Counting objects: 100% (104/104), done.         
remote: Compressing objects:  97% (97/99)         remote: Compressing objects:  98% (98/99)         remote: Compressing objects: 100% (99/99)         remote: Compressing objects: 100% (99/99), done.         
Receiving objects:  98% (396584/404677), 253.96 MiB | 33.60 MiB/s    Receiving objects:  99% (400631/404677), 253.96 MiB | 33.60 MiB/s    Receiving objects:  99% (403419/404677), 253.96 MiB | 33.60 MiB/s    remote: Total 404677 (delta 43), reused 34 (delta 5), pack-reused 404573         
Receiving objects: 100% (404677/404677), 269.05 MiB | 33.52 MiB/s    Receiving objects: 100% (404677/404677), 269.65 MiB | 29.85 MiB/s, done. 
Resolving deltas:  98% (319100/325575)    Resolving deltas:  99% (322321/325575)    Resolving deltas: 100% (325575/325575)    Resolving deltas: 100% (325575/325575), done. 
Warning: Permanently added the RSA host key for IP address '140.82.112.4' to the list of known hosts.  
fatal: couldn't find remote ref more_doc_fixes

See CircleCI build pytorch_libtorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Checkout code" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: couldn't find remote ref more_doc_fixes 
Using SSH Config Dir /home/circleci/.ssh 
Cloning into '.'... 
Warning: Permanently added the RSA host key for IP address '140.82.114.3' to the list of known hosts.  
remote: Enumerating objects: 404573         remote: Enumerating objects: 104, done.         
remote: Counting objects:  98% (102/104)         remote: Counting objects:  99% (103/104)         remote: Counting objects: 100% (104/104)         remote: Counting objects: 100% (104/104), done.         
remote: Compressing objects:  97% (97/99)         remote: Compressing objects:  98% (98/99)         remote: Compressing objects: 100% (99/99)         remote: Compressing objects: 100% (99/99), done.         
Receiving objects:  97% (392537/404677), 256.44 MiB | 39.75 MiB/s    Receiving objects:  98% (396584/404677), 256.44 MiB | 39.75 MiB/s    Receiving objects:  99% (400631/404677), 256.44 MiB | 39.75 MiB/s    remote: Total 404677 (delta 43), reused 34 (delta 5), pack-reused 404573         
Receiving objects: 100% (404677/404677), 256.44 MiB | 39.75 MiB/s    Receiving objects: 100% (404677/404677), 268.45 MiB | 36.61 MiB/s, done. 
Resolving deltas:  98% (319044/325544)    Resolving deltas:  99% (322292/325544)    Resolving deltas: 100% (325544/325544)    Resolving deltas: 100% (325544/325544), done. 
Warning: Permanently added the RSA host key for IP address '140.82.113.4' to the list of known hosts.  
fatal: couldn't find remote ref more_doc_fixes
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@gchanan gchanan gchanan approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mruberry @facebook-github-bot @gchanan