Adds missing abs to lcm #41552
Adds missing abs to lcm #41552
Conversation
💊 CI failures summary and remediationsAs of commit 2ef0e21 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
torch/_torch_docs.py
Outdated
| r""" | ||
| isnan(input) -> Tensor | ||
| Returns a new tensor with boolean elements representing if each element is `NaN` or not. |
| Arguments: | ||
| input (Tensor): A tensor to check | ||
| {input} |
There was a problem hiding this comment.
you are removing comments that input is a Tensor everywhere - is it universally assumed?
There was a problem hiding this comment.
You can see the autogenerated text and formatting for input styled like this in the doc for lgamma, for example: https://pytorch.org/docs/master/generated/torch.lgamma.html?highlight=lgamma#torch.lgamma. So yes, it is assumed.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
lcm was missing an abs. This adds it plus extends the test for NumPy compliance. Also includes a few doc fixes.