[JIT] optimize autodiff subgraph slicing #41437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 78ad02d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 33 times. |
[ghstack-poisoned]
[copied from commented code] the IR has many nodes which can never be reordered around, such as a prim::Bailout. if a node N is surrounded by two nodes which cannot be reordered, A and B, then a differentiable subgraph that is created from N can only contain nodes from [A, B] The nodes from A to B represent one work block for the subgraph slicer to work on. By creating these up front, we avoid retraversing the whole graph block any time scanNode returns, and we can also avoid attempting to create differentiable subgraphs in work blocks that do not contain a minimum number of differentiable nodes This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s. [ghstack-poisoned]
[copied from commented code] the IR has many nodes which can never be reordered around, such as a prim::Bailout. if a node N is surrounded by two nodes which cannot be reordered, A and B, then a differentiable subgraph that is created from N can only contain nodes from [A, B] The nodes from A to B represent one work block for the subgraph slicer to work on. By creating these up front, we avoid retraversing the whole graph block any time scanNode returns, and we can also avoid attempting to create differentiable subgraphs in work blocks that do not contain a minimum number of differentiable nodes This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s. [ghstack-poisoned]
added 4 commits
July 16, 2020 12:58
[copied from commented code] the IR has many nodes which can never be reordered around, such as a prim::Bailout. if a node N is surrounded by two nodes which cannot be reordered, A and B, then a differentiable subgraph that is created from N can only contain nodes from [A, B] The nodes from A to B represent one work block for the subgraph slicer to work on. By creating these up front, we avoid retraversing the whole graph block any time scanNode returns, and we can also avoid attempting to create differentiable subgraphs in work blocks that do not contain a minimum number of differentiable nodes This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s. [ghstack-poisoned]
[copied from commented code] the IR has many nodes which can never be reordered around, such as a prim::Bailout. if a node N is surrounded by two nodes which cannot be reordered, A and B, then a differentiable subgraph that is created from N can only contain nodes from [A, B] The nodes from A to B represent one work block for the subgraph slicer to work on. By creating these up front, we avoid retraversing the whole graph block any time scanNode returns, and we can also avoid attempting to create differentiable subgraphs in work blocks that do not contain a minimum number of differentiable nodes This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s. [ghstack-poisoned]
[copied from commented code] the IR has many nodes which can never be reordered around, such as a prim::Bailout. if a node N is surrounded by two nodes which cannot be reordered, A and B, then a differentiable subgraph that is created from N can only contain nodes from [A, B] The nodes from A to B represent one work block for the subgraph slicer to work on. By creating these up front, we avoid retraversing the whole graph block any time scanNode returns, and we can also avoid attempting to create differentiable subgraphs in work blocks that do not contain a minimum number of differentiable nodes This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s. Differential Revision: [D22600607](https://our.internmc.facebook.com/intern/diff/D22600607) [ghstack-poisoned]
[copied from commented code] the IR has many nodes which can never be reordered around, such as a prim::Bailout. if a node N is surrounded by two nodes which cannot be reordered, A and B, then a differentiable subgraph that is created from N can only contain nodes from [A, B] The nodes from A to B represent one work block for the subgraph slicer to work on. By creating these up front, we avoid retraversing the whole graph block any time scanNode returns, and we can also avoid attempting to create differentiable subgraphs in work blocks that do not contain a minimum number of differentiable nodes This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s. Differential Revision: [D22600607](https://our.internmc.facebook.com/intern/diff/D22600607) [ghstack-poisoned]
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[copied from commented code]
the IR has many nodes which can never be reordered around, such as a
prim::Bailout. if a node N is surrounded by two nodes which cannot be
reordered, A and B, then a differentiable subgraph that is created from N
can only contain nodes from [A, B] The nodes from A to B represent one
work block for the subgraph slicer to work on. By creating these up
front, we avoid retraversing the whole graph block any time scanNode
returns, and we can also avoid attempting to create differentiable
subgraphs in work blocks that do not contain a minimum number of differentiable nodes
This improved compilation time of e of densenet (the model with the slowest compilation time we're tracking) from 56s -> 28s, and for mobilenet from 8s -> 6s.
Differential Revision: D22600607