Skip to content

[vulkan] cat op (concatenate) #41434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IvanKobzarev wants to merge 14 commits into from
Closed

[vulkan] cat op (concatenate) #41434

IvanKobzarev wants to merge 14 commits into from

Conversation

@IvanKobzarev
Copy link
Contributor

@IvanKobzarev IvanKobzarev commented Jul 14, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D22754941

@IvanKobzarev
[vulkan] cat op (concatenate)
ac96391 
[ghstack-poisoned]
This was referenced Jul 14, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dr-ci
Copy link

dr-ci bot commented Jul 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2f8c576 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_cpp_doc_build (1/1)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Aug 10 22:37:57 - [class]: torch::serialize::OutputArchive 
Aug 10 22:37:57     - [function]: torch::python::bind_module 
Aug 10 22:37:57     - [function]: torch::python::bind_module 
Aug 10 22:37:57     - [function]: torch::python::init_bindings 
Aug 10 22:37:57     - [namespace]: torch::python::detail 
Aug 10 22:37:57       - [function]: torch::python::detail::bind_cpp_module_wrapper 
Aug 10 22:37:57       - [function]: torch::python::detail::py_object_to_device 
Aug 10 22:37:57       - [function]: torch::python::detail::py_object_to_dtype 
Aug 10 22:37:57       - [typedef]: torch::python::detail::PyModuleClass 
Aug 10 22:37:57   - [namespace]: torch::serialize 
Aug 10 22:37:57     - [class]: torch::serialize::InputArchive 
Aug 10 22:37:57     - [class]: torch::serialize::OutputArchive 
Aug 10 22:37:57   - [typedef]: torch::AutoGradMode 
Aug 10 22:37:57   - [typedef]: torch::Deleter 
Aug 10 22:37:57   - [typedef]: torch::Dtype 
Aug 10 22:37:57   - [typedef]: torch::NoGradGuard 
Aug 10 22:37:57   - [variable]: torch::kArea 
Aug 10 22:37:57   - [variable]: torch::kBatchMean 
Aug 10 22:37:57   - [variable]: torch::kBicubic 
Aug 10 22:37:57   - [variable]: torch::kBilinear 
Aug 10 22:37:57   - [variable]: torch::kBorder 
Aug 10 22:37:57   - [variable]: torch::kCircular

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 45 times.

@IvanKobzarev
Update on "[vulkan] cat op (concatenate)"
aa9d35e 
[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan] cat op (concatenate)"
7c8f84a 
Differential Revision: [D22754941](https://our.internmc.facebook.com/intern/diff/D22754941)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan] cat op (concatenate)"
3941eba 
Differential Revision: [D22754941](https://our.internmc.facebook.com/intern/diff/D22754941)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan] cat op (concatenate)"
af8b1e1 
Differential Revision: [D22754941](https://our.internmc.facebook.com/intern/diff/D22754941)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan] cat op (concatenate)"
98a799a 
Differential Revision: [D22754941](https://our.internmc.facebook.com/intern/diff/D22754941)

[ghstack-poisoned]
@IvanKobzarev
Update on "[vulkan] cat op (concatenate)"
ca1bdb0 
Differential Revision: [D22754941](https://our.internmc.facebook.com/intern/diff/D22754941)

[ghstack-poisoned]
This was referenced Jul 28, 2020
Closed
Closed
Closed
AshkanAliabadi
AshkanAliabadi approved these changes Aug 6, 2020
View reviewed changes
aten/src/ATen/native/vulkan/VulkanAten.cpp Outdated
input.options());
}

at::Tensor vulkan_cat(TensorList tensors, int64_t dim) {
Copy link
Contributor

@AshkanAliabadi AshkanAliabadi Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const TensorList&

Copy link
Contributor Author

@IvanKobzarev IvanKobzarev Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TensorList is an alias to ArrayRef<Tensor>, thats why reference to it will not work:

terminate called after throwing an instance of 'c10::Error'
  what():  *cpp_signature == *cpp_signature_ INTERNAL ASSERT FAILED at "../aten/src/ATen/core/dispatch/OperatorEntry.cpp":93, please report a bug to PyTorch. Tried to register a kernel (registered at ../aten/src/ATen/native/vulkan/VulkanAten.cpp:618) for operator aten::_cat for dispatch key Vulkan, but the C++ function signature at::Tensor (c10::ArrayRef<at::Tensor> const&, long) mismatched with a previous kernel that had the signature at::Tensor (c10::ArrayRef<at::Tensor>, long)
Exception raised from registerKernel at ../aten/src/ATen/core/dispatch/OperatorEntry.cpp:93 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::string) + 0x4d (0x7f155c08477d in /home/ivankobzarev/pytorch-vulkan/pytorch/build/lib/libc10.so)

But const works , I will add it

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2020

@IvanKobzarev merged this pull request in 8718524.

@facebook-github-bot facebook-github-bot deleted the gh/IvanKobzarev/59/head branch August 14, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss Awaiting requested review from dreiss

1 more reviewer

@AshkanAliabadi AshkanAliabadi AshkanAliabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanKobzarev @facebook-github-bot @AshkanAliabadi @mruberry