.circleci: Explicitly remove nvidia apt repos #41367
Conversation
The nvidia apt repositories seem to be left over on the amd nodes so let's just go ahead and remove them explicitly if we're not testing for CUDA Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
This is so janky. I have a recommendation for a follow up: let's make the ROCm workers STOP using setup_ci_environment.sh, and give them a dedicated bash script that very LOUDLY says that "these changes are permanent to the workers and not reset across runs"
Agreed, I also think general we should try to move away from |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Can't do that, this environment setup is for installing nvidia-docker so we can run the docker image in the first place ;) |
|
@seemethere merged this pull request in b6e1944. |
5 participants
The nvidia apt repositories seem to be left over on the amd nodes so
let's just go ahead and remove them explicitly if we're not testing for
CUDA
Example: https://app.circleci.com/pipelines/github/pytorch/pytorch/190222/workflows/8f75b5cd-1afd-43dc-9fa7-f7b058f07b46/jobs/6223743/steps
Signed-off-by: Eli Uriegas eliuriegas@fb.com