Skip to content

Add an option to suppress download progress #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ezyang merged 3 commits into from
Dec 15, 2017
Merged

Add an option to suppress download progress #4135

ezyang merged 3 commits into from
Dec 15, 2017

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Dec 12, 2017

apaszke
apaszke reviewed Dec 12, 2017
View reviewed changes
torch/utils/model_zoo.py Outdated
sha256.update(buffer)
pbar.update(len(buffer))
if progress:
pbar.update(len(buffer))

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

colesbury
colesbury reviewed Dec 13, 2017
View reviewed changes
torch/utils/model_zoo.py


def load_url(url, model_dir=None, map_location=None):
def load_url(url, model_dir=None, map_location=None, progress=True):

This comment was marked as off-topic.

Sign in to view

@ezyang ezyang merged commit d8d82d1 into pytorch:master Dec 15, 2017
@bddppq
Copy link
Contributor Author

bddppq commented Dec 15, 2017

@ezyang Sorry I forgot to follow up on this. Thanks for updating the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury left review comments

+1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bddppq @colesbury @apaszke @ezyang