Calculate inverse of output scale first. #41342
Conversation
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kimishpatel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
should this be multiplying by inv_output_scale?
There was a problem hiding this comment.
Aaaah. yes. Some changes got dropped by me I think.
kimishpatel
force-pushed
the
inverse_output_scale
branch
from
503d620 to
79a90ba
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kimishpatel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kimishpatel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kimishpatel
force-pushed
the
inverse_output_scale
branch
from
79a90ba to
1d7a6f4
Compare
Summary: This is to unify how output scale calculation is to be done between fbgemm and qnnpack (servers vs mobile). Test Plan: Quantization tests. Reviewers: Subscribers: Tasks: Tags:
kimishpatel
force-pushed
the
inverse_output_scale
branch
from
1d7a6f4 to
5b24352
Compare
💊 CI failures summary and remediationsAs of commit 5b24352 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kimishpatel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@kimishpatel merged this pull request in f0fd1cc. |
Summary:
This is to unify how output scale calculation is to be done between
fbgemm and qnnpack (servers vs mobile).
Test Plan:
Quantization tests.
Reviewers:
Subscribers:
Tasks:
Tags: