Skip to content

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jul 8, 2020

Stack from ghstack:

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D22446714

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner July 8, 2020 23:45
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 8, 2020
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 8, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 9adad5a
Pull Request resolved: #41161
@dr-ci
Copy link

dr-ci bot commented Jul 9, 2020

💊 CI failures summary and remediations

As of commit dc8b23a (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 32 times.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
@eellison
Copy link
Contributor

eellison commented Jul 9, 2020

fyi, the file got moved to remove_mutation.h

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 9, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 9f39e1a
Pull Request resolved: #41161
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 9, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e46d2d3
Pull Request resolved: #41161
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 9, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 4d1377c
Pull Request resolved: #41161
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 9, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c627baf
Pull Request resolved: #41161
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 10, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3cd8cbd
Pull Request resolved: #41161
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D22446714](https://our.internmc.facebook.com/intern/diff/D22446714)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jul 10, 2020
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c0b6b54
Pull Request resolved: #41161
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4b4184f.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/379/head branch July 15, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants